Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cuco isn't a cudf dependency when we are built shared #10662

Conversation

robertmaynard
Copy link
Contributor

With the corrections in #10545 we didn't install the cuco headers / cmake files as they aren't needed for shared builds. But we forgot to remove the find_package(cuco) call from the generated cudf-config.cmake.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Apr 14, 2022
@robertmaynard robertmaynard requested a review from trxcllnt April 14, 2022 18:57
@robertmaynard robertmaynard requested a review from a team as a code owner April 14, 2022 18:57
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #10662 (82fe1ab) into branch-22.06 (3c13ef1) will increase coverage by 0.03%.
The diff coverage is 89.52%.

@@               Coverage Diff                @@
##           branch-22.06   #10662      +/-   ##
================================================
+ Coverage         86.33%   86.37%   +0.03%     
================================================
  Files               140      142       +2     
  Lines             22289    22356      +67     
================================================
+ Hits              19244    19310      +66     
- Misses             3045     3046       +1     
Impacted Files Coverage Δ
python/cudf/cudf/core/algorithms.py 90.47% <ø> (ø)
python/cudf/cudf/core/groupby/groupby.py 91.72% <ø> (+0.22%) ⬆️
python/cudf/cudf/core/multiindex.py 92.14% <ø> (ø)
python/cudf/cudf/core/series.py 95.28% <ø> (ø)
python/cudf/cudf/utils/cudautils.py 59.83% <ø> (ø)
python/cudf/cudf/utils/ioutils.py 79.60% <ø> (ø)
python/cudf/cudf/utils/utils.py 90.28% <ø> (ø)
python/cudf/cudf/core/frame.py 93.67% <56.52%> (-1.09%) ⬇️
python/dask_cudf/dask_cudf/tests/utils.py 90.90% <90.90%> (ø)
python/cudf/cudf/core/column/lists.py 92.79% <100.00%> (+1.38%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac27757...82fe1ab. Read the comment docs.

@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b542678 into rapidsai:branch-22.06 Apr 15, 2022
@robertmaynard robertmaynard deleted the bug/cuco_isnt_an_install_requirement branch April 15, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants