Skip to content

Commit

Permalink
cuco isn't a cudf dependency when we are built shared (#10662)
Browse files Browse the repository at this point in the history
With the corrections in #10545 we didn't install the cuco headers / cmake files as they aren't needed for shared builds. But we forgot to remove the `find_package(cuco)` call from the generated cudf-config.cmake.

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Paul Taylor (https://github.com/trxcllnt)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #10662
  • Loading branch information
robertmaynard authored Apr 15, 2022
1 parent 8f5a044 commit b542678
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion cpp/cmake/thirdparty/get_cucollections.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,14 @@ function(find_and_configure_cucollections)
cuco 0.0.1
GLOBAL_TARGETS cuco::cuco
BUILD_EXPORT_SET cudf-exports
INSTALL_EXPORT_SET cudf-exports
CPM_ARGS GITHUB_REPOSITORY NVIDIA/cuCollections
GIT_TAG fb58a38701f1c24ecfe07d8f1f208bbe80930da5
EXCLUDE_FROM_ALL ${BUILD_SHARED_LIBS}
OPTIONS "BUILD_TESTS OFF" "BUILD_BENCHMARKS OFF" "BUILD_EXAMPLES OFF"
)
if(NOT BUILD_SHARED_LIBS)
rapids_export_package(INSTALL cuco cudf-exports)
endif()

endfunction()

Expand Down

0 comments on commit b542678

Please sign in to comment.