-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle RuntimeError thrown by CUDA Python in validate_setup
#10653
Merged
rapids-bot
merged 2 commits into
rapidsai:branch-22.06
from
shwina:validate-setup-catch-rt-error
Apr 19, 2022
Merged
Handle RuntimeError thrown by CUDA Python in validate_setup
#10653
rapids-bot
merged 2 commits into
rapidsai:branch-22.06
from
shwina:validate-setup-catch-rt-error
Apr 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shwina
commented
Apr 13, 2022
shwina
commented
Apr 13, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10653 +/- ##
================================================
+ Coverage 86.31% 86.39% +0.07%
================================================
Files 140 142 +2
Lines 22280 22318 +38
================================================
+ Hits 19232 19281 +49
+ Misses 3048 3037 -11
Continue to review full report at Codecov.
|
shwina
added
non-breaking
Non-breaking change
improvement
Improvement / enhancement to an existing function
labels
Apr 14, 2022
charlesbluca
approved these changes
Apr 19, 2022
galipremsagar
approved these changes
Apr 19, 2022
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
getDeviceCount()
can raise aRuntimeError
whenlibcuda.so
is missing. We should handle that too invalidate_setup()
.