Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle RuntimeError thrown by CUDA Python in validate_setup #10653

Merged

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Apr 13, 2022

The call to getDeviceCount() can raise a RuntimeError when libcuda.so is missing. We should handle that too in validate_setup().

@shwina shwina requested a review from a team as a code owner April 13, 2022 18:21
@shwina shwina requested review from vyasr and skirui-source April 13, 2022 18:21
@github-actions github-actions bot added the Python Affects Python cuDF API. label Apr 13, 2022
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #10653 (bf9f6f7) into branch-22.06 (26c1810) will increase coverage by 0.07%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           branch-22.06   #10653      +/-   ##
================================================
+ Coverage         86.31%   86.39%   +0.07%     
================================================
  Files               140      142       +2     
  Lines             22280    22318      +38     
================================================
+ Hits              19232    19281      +49     
+ Misses             3048     3037      -11     
Impacted Files Coverage Δ
python/cudf/cudf/utils/gpu_utils.py 50.00% <0.00%> (-4.29%) ⬇️
python/cudf/cudf/core/frame.py 93.54% <0.00%> (-1.22%) ⬇️
python/dask_cudf/dask_cudf/tests/test_binops.py 92.00% <0.00%> (-0.60%) ⬇️
python/cudf/cudf/core/reshape.py 89.82% <0.00%> (-0.27%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.36% <0.00%> (-0.27%) ⬇️
python/cudf/cudf/comm/gpuarrow.py 79.76% <0.00%> (-0.24%) ⬇️
python/cudf/cudf/core/series.py 95.15% <0.00%> (-0.13%) ⬇️
python/cudf/cudf/core/cut.py 82.69% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 79.60% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 89.45% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00fce5a...bf9f6f7. Read the comment docs.

@shwina shwina closed this Apr 13, 2022
@shwina shwina reopened this Apr 14, 2022
@shwina shwina added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Apr 14, 2022
@shwina
Copy link
Contributor Author

shwina commented Apr 19, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 304711a into rapidsai:branch-22.06 Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants