Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] dask_sql does not import on CPU CI when RAPIDS is installed #473

Closed
lmeyerov opened this issue Apr 13, 2022 · 4 comments · Fixed by #480
Closed

[BUG] dask_sql does not import on CPU CI when RAPIDS is installed #473

lmeyerov opened this issue Apr 13, 2022 · 4 comments · Fixed by #480
Labels
bug Something isn't working needs triage Awaiting triage by a dask-sql maintainer

Comments

@lmeyerov
Copy link

lmeyerov commented Apr 13, 2022

What happened:

import dask_sql throws RuntimeError

This is due to not handling that import dask_cudf in RAPIDS 22.04 may now throw RuntimeError (vs just ImportError)

The env scenario where this would happen is a CPU box that has (inactive) rapids libs. E.g., CPU CI, or a universal distro, where rapids python is installed in the env, but there is no actual libcuda, and the user is planning to use just cpu paths with dask_sql

This is a continuation of upstream issue rapidsai/rmm#1022

What you expected to happen:

import dask_sql

to import without exn and not use a GPU

Minimal Complete Verifiable Example:

See rapidsai/rmm#1022

Anything else we need to know?:

A hotfix for 22.04 may be to catch RuntimeError during the import dask_cudf catch block, and re-release to conda. TBD if RAPIDS will re-release 22.04 (e.g., containers) after this.

The long-term fix is unclear b/c RAPIDS is trying to decide how this scenario should behave..

Environment:

  • dask-sql version: 22.04
  • Python version: 3.8
  • Operating System: ubuntu
  • Install method (conda, pip, source):
  • cpu docker host
  • rapids base container (22.04)
@lmeyerov lmeyerov added bug Something isn't working needs triage Awaiting triage by a dask-sql maintainer labels Apr 13, 2022
@charlesbluca
Copy link
Collaborator

Thanks for raising this issue @lmeyerov! As mentioned in rapidsai/rmm#1022, this should be resolved on cuDF's end with rapidsai/cudf#10653.

However, I do think that this issue serves as good motivation to move the cuDF / dask-cuDF imports in dask-sql so that they only occur if a user attempts to do GPU operations - this ensures that an issue like this shouldn't cause issues for us in the future. I will follow up with a PR closing this issue 🙂

@charlesbluca
Copy link
Collaborator

Opened #480 which should resolve this issue

@charlesbluca
Copy link
Collaborator

Hey @lmeyerov this change is now incorporated into the latest dask-sql nightlies - not sure if you are pulling those for Graphistry CI but the issue should now be resolved on both ends 😄 feel free to reopen if this problem seems to be persisting

@lmeyerov
Copy link
Author

Thanks! RAPIDS fixed on their side as well, and good to know no repeats going forward in case they regress again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Awaiting triage by a dask-sql maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants