-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify preprocessing of arguments for DataFrame binops #10563
Simplify preprocessing of arguments for DataFrame binops #10563
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10563 +/- ##
================================================
+ Coverage 86.33% 86.37% +0.03%
================================================
Files 140 140
Lines 22300 22304 +4
================================================
+ Hits 19253 19265 +12
+ Misses 3047 3039 -8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the PR looks good, I have some minor comments.
bb6b309
to
46fd129
Compare
@gpucibot merge |
This PR simplifies the preprocessing of the rhs of binary operations for DataFrame, streamlining it to a single path that can be more easily combined with that of other types in the future.