Skip to content

Commit

Permalink
Address PR comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
vyasr committed Apr 12, 2022
1 parent db84ddf commit 46fd129
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion python/cudf/cudf/core/dataframe.py
Original file line number Diff line number Diff line change
Expand Up @@ -1865,7 +1865,7 @@ def _make_operands_and_index_for_binop(
)
if len(other) != self._num_columns:
raise ValueError(
"Other is the wrong length. Expected "
"Other is of the wrong length. Expected "
f"{self._num_columns}, got {len(other)}"
)

Expand Down
5 changes: 5 additions & 0 deletions python/cudf/cudf/tests/test_dataframe.py
Original file line number Diff line number Diff line change
Expand Up @@ -2106,6 +2106,11 @@ def test_binops_df(pdf, gdf, binop, other):
pass


def test_binops_df_invalid(gdf):
with pytest.raises(TypeError):
gdf + np.array([1, 2])


@pytest.mark.parametrize("binop", [operator.and_, operator.or_, operator.xor])
def test_bitwise_binops_df(pdf, gdf, binop):
d = binop(pdf, pdf + 1)
Expand Down

0 comments on commit 46fd129

Please sign in to comment.