Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove statically linked CUDA runtime check in Java build #10532

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Mar 29, 2022

#9873 added static linking of the CUDA runtime by default in Java cudf builds from the build-in-docker.sh. At the end of the script is a sanity check that the CUDA runtime is not statically linked which should have been removed, but it fails to trigger due to an empty .so file found during the build that causes an error in readelf and prevents the script from exiting early. This PR removes the check since a statically linked CUDA runtime is supported and tested.

@jlowe jlowe added bug Something isn't working Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer non-breaking Non-breaking change labels Mar 29, 2022
@jlowe jlowe requested a review from a team as a code owner March 29, 2022 14:55
@jlowe jlowe self-assigned this Mar 29, 2022
Copy link
Contributor

@jbrennan333 jbrennan333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 lgtm

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.06@a0495f4). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.06   #10532   +/-   ##
===============================================
  Coverage                ?   86.34%           
===============================================
  Files                   ?      140           
  Lines                   ?    22302           
  Branches                ?        0           
===============================================
  Hits                    ?    19257           
  Misses                  ?     3045           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0495f4...4fffcd5. Read the comment docs.

@jlowe
Copy link
Member Author

jlowe commented Mar 29, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cc986f7 into rapidsai:branch-22.06 Mar 29, 2022
@jlowe jlowe deleted the jni-rm-static-check branch March 29, 2022 18:41
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants