Skip to content

Commit

Permalink
Remove statically linked CUDA runtime check in Java build (#10532)
Browse files Browse the repository at this point in the history
#9873 added static linking of the CUDA runtime by default in Java cudf builds from the `build-in-docker.sh`.  At the end of the script is a sanity check that the CUDA runtime is _not_ statically linked which should have been removed, but it fails to trigger due to an empty `.so` file found during the build that causes an error in `readelf` and prevents the script from exiting early. This PR removes the check since a statically linked CUDA runtime is supported and tested.

Authors:
  - Jason Lowe (https://github.com/jlowe)

Approvers:
  - Jim Brennan (https://github.com/jbrennan333)
  - Gera Shegalov (https://github.com/gerashegalov)

URL: #10532
  • Loading branch information
jlowe authored Mar 29, 2022
1 parent b926f51 commit cc986f7
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions java/ci/build-in-docker.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash

#
# Copyright (c) 2020-2021, NVIDIA CORPORATION. All rights reserved.
# Copyright (c) 2020-2022, NVIDIA CORPORATION. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -93,9 +93,6 @@ fi
cd "$WORKSPACE/java"
mvn -B clean package $BUILD_ARG

###### Sanity test: fail if static cudart found ######
find . -name '*.so' | xargs -I{} readelf -Ws {} | grep cuInit && echo "Found statically linked CUDA runtime, this is currently not tested" && exit 1

###### Stash Jar files ######
rm -rf $OUT_PATH
mkdir -p $OUT_PATH
Expand Down

0 comments on commit cc986f7

Please sign in to comment.