Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set column names in _from_columns_like_self factory #10400

Merged

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Mar 8, 2022

A quick fix to set column names in the _from_columns_like_self factory. Since dataframe column names are slightly more complex than simple Frame, this fix makes sure column name metadata (such as multi level names) are properly copied to the result dataframe.

Addresses this comment: #10315 (comment)

@isVoid isVoid added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function labels Mar 8, 2022
@isVoid isVoid requested a review from vyasr March 8, 2022 22:35
@isVoid isVoid self-assigned this Mar 8, 2022
@isVoid isVoid requested a review from a team as a code owner March 8, 2022 22:35
@isVoid isVoid requested a review from trxcllnt March 8, 2022 22:35
@isVoid isVoid added the non-breaking Non-breaking change label Mar 8, 2022
@isVoid isVoid requested a review from galipremsagar March 9, 2022 23:47
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #10400 (25e9527) into branch-22.04 (b3dc9d6) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10400      +/-   ##
================================================
+ Coverage         86.12%   86.16%   +0.03%     
================================================
  Files               139      139              
  Lines             22450    22465      +15     
================================================
+ Hits              19336    19357      +21     
+ Misses             3114     3108       -6     
Impacted Files Coverage Δ
python/cudf/cudf/core/frame.py 91.73% <ø> (+<0.01%) ⬆️
python/cudf/cudf/core/dataframe.py 93.57% <100.00%> (+<0.01%) ⬆️
python/cudf/cudf/core/single_column_frame.py 97.03% <0.00%> (-0.03%) ⬇️
python/cudf/cudf/core/series.py 95.16% <0.00%> (-0.01%) ⬇️
python/cudf/cudf/io/csv.py 91.80% <0.00%> (ø)
python/cudf/cudf/io/text.py 100.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 92.70% <0.00%> (ø)
python/cudf/cudf/core/udf/utils.py 98.63% <0.00%> (ø)
python/dask_cudf/dask_cudf/core.py 73.36% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 92.13% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3dc9d6...25e9527. Read the comment docs.

@isVoid
Copy link
Contributor Author

isVoid commented Mar 10, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 289a6a1 into rapidsai:branch-22.04 Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants