Remove internal columns usage #10315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
2 - In Progress
vyasr
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10315 +/- ##
================================================
- Coverage 10.62% 10.62% -0.01%
================================================
Files 122 122
Lines 20961 20973 +12
================================================
Hits 2228 2228
- Misses 18733 18745 +12
Continue to review full report at Codecov.
|
… for dataframe,series,index,and multiindex tests to pass.
vyasr
force-pushed
the
refactor/remove_internal_columns_usage
branch
from
3cb216e to
102ccef
Compare
isVoid
reviewed
Feb 22, 2022
That's definitely a good idea for a follow-up PR, but I think it's out of scope for this one. |
isVoid
approved these changes
Feb 23, 2022
|
@gpucibot merge |
This was referenced Mar 8, 2022
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 10, 2022
A quick fix to set column names in the `_from_columns_like_self` factory. Since dataframe column names are slightly more complex than simple Frame, this fix makes sure column name metadata (such as multi level names) are properly copied to the result dataframe. Addresses this comment: #10315 (comment) Authors: - Michael Wang (https://github.com/isVoid) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #10400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the feature introduced in #10263 to remove the usage of DataFrame.columns where possible.
Currently this removes a large number of internal uses but not all of them to verify that CI does indeed fail as expected since some changes were made on #10263 after the last test of CI by reviewer request. I will convert this from a draft once I see CI fail and once all the necessary changes have been made for tests to pass.