Create a dispatcher for invoking regex kernel functions #10349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10349 +/- ##
=============================================
Coverage 10.58% 10.58%
=============================================
Files 125 125
Lines 21058 21058
=============================================
Hits 2228 2228
Misses 18830 18830 Continue to review full report at Codecov.
|
davidwendt
added
3 - Ready for Review
vyasr
approved these changes
Feb 25, 2022
cwharris
approved these changes
Mar 1, 2022
bdice
requested changes
Mar 1, 2022
bdice
approved these changes
Mar 1, 2022
rgsl888prabhu
approved these changes
Mar 2, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10138
Refactor the various regex function calls to use a dispatcher instead of if-else clauses. Each regex call currently requires different stack sizes (and later launch parameters). Changes to these parameters are sometimes difficult to coordinate since they usually need to be duplicated across about 10 APIs that are currently using regex calls. The new
regex_dispatchermakes calling these much cleaner and easier to maintain. This will be helpful when experimenting with possibly using different launch parameters.No functions have changed. Mostly this is a refactoring and cleanup effort. The
findall.cuwas also recoded to use the newcount_matchesutility.