Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create dispatcher for different regex stack sizes #10138

Closed
vyasr opened this issue Jan 26, 2022 · 0 comments · Fixed by #10349
Closed

Create dispatcher for different regex stack sizes #10138

vyasr opened this issue Jan 26, 2022 · 0 comments · Fixed by #10349
Assignees
@davidwendt
Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python)

Comments

@vyasr
Copy link
Contributor

vyasr commented Jan 26, 2022

This dispatch pattern must be common throughout regex codes. Could we implement a dispatcher for this based on floor(regex_insts)? Feel free to push to future work, no need to clutter this PR even if you think it's a good idea, I just wanted to mention it while it's fresh.

Originally posted by @vyasr in #9911 (comment)
@vyasr vyasr added Needs Triage Need team to review and classify improvement Improvement / enhancement to an existing function labels Jan 26, 2022
@vyasr vyasr mentioned this issue Jan 26, 2022
Merged
@davidwendt davidwendt added libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) labels Jan 26, 2022
@davidwendt davidwendt self-assigned this Feb 2, 2022
@davidwendt davidwendt mentioned this issue Feb 23, 2022
Merged
@vyasr vyasr mentioned this issue Feb 23, 2022
Closed
7 tasks
rapids-bot bot pushed a commit that referenced this issue Mar 2, 2022
@davidwendt
Create a dispatcher for invoking regex kernel functions (#10349)
1217f24 
Closes #10138 

Refactor the various regex function calls to use a dispatcher instead of if-else clauses. Each regex call currently requires different stack sizes (and later launch parameters). Changes to these parameters are sometimes difficult to coordinate since they usually need to be duplicated across about 10 APIs that are currently using regex calls. The new `regex_dispatcher` makes calling these much cleaner and easier to maintain. This will be helpful when experimenting with possibly using different launch parameters.

No functions have changed. Mostly this is a refactoring and cleanup effort. The `findall.cu` was also recoded to use the new `count_matches` utility.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Christopher Harris (https://github.com/cwharris)
  - Bradley Dice (https://github.com/bdice)
  - Ram (Ramakrishna Prabhu) (https://github.com/rgsl888prabhu)

URL: #10349
@bdice bdice removed the Needs Triage Need team to review and classify label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwendt davidwendt

Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create a dispatcher for invoking regex kernel functions davidwendt/cudf
3 participants
@vyasr @bdice @davidwendt