Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix codecov in CI #10347

Merged
merged 15 commits into from
Mar 8, 2022
+5 −6
Merged

[REVIEW] Fix codecov in CI #10347

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f10d20d
try to fix codecov
galipremsagar Feb 23, 2022
8435624
Update build.sh
galipremsagar Feb 24, 2022
c02a8c1
Update .coveragerc
galipremsagar Feb 24, 2022
06db682
Update build.sh
galipremsagar Feb 24, 2022
24d9c7c
Update python/cudf/.coveragerc
galipremsagar Feb 24, 2022
310ad74
Update build.sh
galipremsagar Feb 24, 2022
1f2fad3
Update build.sh
galipremsagar Mar 7, 2022
db8f309
Merge branch 'rapidsai:branch-22.04' into codecov_fix
galipremsagar Mar 7, 2022
87f5213
Merge branch 'rapidsai:branch-22.04' into codecov_fix
galipremsagar Mar 7, 2022
51071ce
Update build.sh
galipremsagar Mar 7, 2022
17cbe52
Update build.sh
galipremsagar Mar 7, 2022
0b14c9f
Update ci/gpu/build.sh
galipremsagar Mar 7, 2022
700d692
Update .coveragerc
galipremsagar Mar 7, 2022
094fa0c
Update .coveragerc
galipremsagar Mar 7, 2022
cc78c48
Update python/dask_cudf/.coveragerc
galipremsagar Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ci/gpu/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,9 +239,9 @@ fi
# TEST - Run py.test, notebooks
################################################################################

cd "$WORKSPACE/python/cudf"
cd "$WORKSPACE/python/cudf/cudf"
gpuci_logger "Python py.test for cuDF"
py.test -n 8 --cache-clear --basetemp="$WORKSPACE/cudf-cuda-tmp" --ignore="$WORKSPACE/python/cudf/cudf/benchmarks" --junitxml="$WORKSPACE/junit-cudf.xml" -v --cov-config=.coveragerc --cov=cudf --cov-report=xml:"$WORKSPACE/python/cudf/cudf-coverage.xml" --cov-report term --dist=loadscope cudf
py.test -n 8 --cache-clear --basetemp="$WORKSPACE/cudf-cuda-tmp" --ignore="$WORKSPACE/python/cudf/cudf/benchmarks" --junitxml="$WORKSPACE/junit-cudf.xml" -v --cov-config=../.coveragerc --cov=cudf --cov-report=xml:"$WORKSPACE/python/cudf/cudf-coverage.xml" --cov-report term --dist=loadscope cudf
galipremsagar marked this conversation as resolved.
Show resolved Hide resolved

cd "$WORKSPACE/python/dask_cudf"
gpuci_logger "Python py.test for dask-cudf"
Expand Down
4 changes: 2 additions & 2 deletions python/cudf/.coveragerc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Configuration file for Python coverage tests
[run]
include = cudf/*
omit = cudf/tests/*
source = cudf/*
galipremsagar marked this conversation as resolved.
Show resolved Hide resolved
omit = cudf/tests/*
Copy link
Contributor

@bdice bdice Mar 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to omit our tests? Unused functions in our tests should be flagged as "not covered."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why it was omitted previously, but I'll enable it.