-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Fix codecov
in CI
#10347
[REVIEW] Fix codecov
in CI
#10347
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10347 +/- ##
=================================================
+ Coverage 10.42% 86.13% +75.71%
=================================================
Files 119 139 +20
Lines 20603 22433 +1830
=================================================
+ Hits 2148 19323 +17175
+ Misses 18455 3110 -15345
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! It may also be nice at some point to enable the cython.Coverage
plugin so that we can get coverage results for our Cython code, but the pending switch to scikit-build will bork that anyway so let's not bother with enabling coverage until we can improve scikit-build/coverage compatibility.
ci/gpu/build.sh
Outdated
@@ -239,9 +239,10 @@ fi | |||
# TEST - Run py.test, notebooks | |||
################################################################################ | |||
|
|||
cd "$WORKSPACE/python/cudf" | |||
cd "$WORKSPACE/python/cudf/cudf" | |||
# It is essential to cd into $WORKSPACE/python/cudf/cudf as `pytest-xdist` + `codecov` seem to work only at this directory level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, coverage.py is extremely sensitive to file paths unfortunately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are any changes needed to measure coverage for dask-cudf and custreamz, or are those already working? Let's try to align coverage for all the Python package tests in this PR if possible.
python/cudf/.coveragerc
Outdated
source = cudf | ||
omit = cudf/tests/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really want to omit our tests? Unused functions in our tests should be flagged as "not covered."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why it was omitted previously, but I'll enable it.
Co-authored-by: Bradley Dice <[email protected]>
Yea, they seem to be already working. |
For this PR, I see https://github.com/rapidsai/cudf/blob/branch-22.04/python/dask_cudf/.coveragerc is skipping coverage for dask_cudf tests. I would recommend the same change we made for cudf, don't ignore coverage in test files. For a follow-up, it looks like |
Co-authored-by: Bradley Dice <[email protected]>
Made the changes.
Those are very long-running tests as they target at the machine limits dataset sizes. Hence they are not intended to be run per PR. So we are planning on running them on benchmark machines soon. |
Right, I know fuzz testing is typically large-scale. I was wondering if there are options to use "toy" dataset sizes that can run quickly, to permit CI testing that ensures the code works and has reasonable coverage. edit: A related problem is that we don't build or run libcudf benchmarks in CI, and sometimes PRs are merged that introduce problems in the benchmarks because we don't build them in CI (even if they didn't execute, proving they compile would be beneficial). Being able to run "CI-friendly" versions of long-running code could be helpful. Regardless, it's out of scope for this PR. Very nice job on this. 👍 |
Yeah, I think that is reasonable and possible, I'll try this in a follow-up PR. |
@gpucibot merge |
1 similar comment
@gpucibot merge |
This PR fixes
codecov
reports generation when used withpytest-xdist
.