-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warnings from pandas in test_array_ufunc.py. #10324
Fix warnings from pandas in test_array_ufunc.py. #10324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol when I merged these changes I definitely wondered whether you would find these as part of your warnings hunt before I could get around to fixing them once I finalize ufuncs. Thanks for the fix.
Is there a message regex that we could use in filterwarnings
to ensure that we only catch the expected warnings (out of range args for inverse sin functions, etc)? Not a must, just a suggestion if it's easy. I don't remember exactly what warnings come up but I believe that all the functions that you have put into the list are domain errors.
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10324 +/- ##
================================================
+ Coverage 10.42% 10.63% +0.21%
================================================
Files 119 122 +3
Lines 20603 20940 +337
================================================
+ Hits 2148 2228 +80
- Misses 18455 18712 +257
Continue to review full report at Codecov.
|
@gpucibot merge |
This PR hides pandas warnings in
test_array_ufunc.py
. (I am working through one test file at a time so we can enable-Werr
in the future.) These warnings come from specific functions likearccos
for which the provided integer inputs are out-of-range. It is fine for us to hide these warnings because they do not come from cudf.Alternatives and why I chose against them: