Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Hide warnings from pandas in test_array_ufunc.py. (#10324)
This PR hides pandas warnings in `test_array_ufunc.py`. (I am working through one test file at a time so we can enable `-Werr` in the future.) These warnings come from specific functions like `arccos` for which the provided integer inputs are out-of-range. It is fine for us to hide these warnings because they do not come from cudf. Alternatives and why I chose against them: - Why not limit the test data input to be in the domain of the ufunc? Limiting data inputs would hide the warning. However, it would decrease our coverage that ensures cudf and pandas agree on those results for values outside the domain of the ufunc (particularly trigonometric functions). It would additionally require inputs to be generated based on the ufunc, which would be lengthy. - Why not make cudf raise a warning and ensure that pandas/cudf agree on warning behavior? I chose against this because we generally avoid data introspection in cudf, and this would involve a significantly more complex approach to ufunc execution. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Vyas Ramasubramani (https://github.com/vyasr) URL: #10324
- Loading branch information