List element Equality comparator #10289
Conversation
Many iterations already happened. I just realized late that I should commit
sliced no longer works
github-actions
bot
added
CMake
There was a problem hiding this comment.
I can't seem to comment on the start indexes discussion anymore, but the commit you linked shows a good example of what you're aiming for so I'm going to go ahead and resolve that discussion. There are a couple of small outstanding tasks (documenting the safe template parameter and making a decision on the curr_col/temp_col/prev_col naming) but otherwise LGTM! Really awesome work here.
| void const* data, | ||
| bitmask_type const* null_mask, | ||
| size_type offset) | ||
| CUDF_HOST_DEVICE column_device_view_base(data_type type, |
There was a problem hiding this comment.
strictly speaking, this macro is really only necessary in a .hpp file that is expected to work in both host and device code TUs.
There was a problem hiding this comment.
Change made as part of this feedback #10289 (comment). I can revert the macro changes made to all .cuh headers.
There was a problem hiding this comment.
strictly speaking, this macro is really only necessary in a .hpp file that is expected to work in both host and device code TUs.
I agree that it's not necessary in cuh. I made this suggestion because not everyone will think about that and people will invariably copy-paste, so uniformly using CUDF_HOST_DEVICE helps reduce the chance of future errors and leaves one less thing for developers to think about. It's a minor suggestion though, if you prefer to use it more surgically that's OK with me.
|
rerun tests |
|
@gpucibot merge |
|
The merge is blocked by needing an ops review because of the one-line change to the conda recipe. I've made that request. |
This PR implements equality comparator for LIST columns. This only supports "self" comparison for now, meaning the two rows to be compared should belong to the same table. A comparator that works on rows of two different tables will be implemented in another PR.
This works only on "sanitized" list columns. See #10291 for details.
This will partially support #10186.