-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move input generation for copy benchmark to device #10279
Merged
rapids-bot
merged 3 commits into
rapidsai:branch-22.04
from
karthikeyann:fea-benchmark_speedup_2.3
Feb 17, 2022
Merged
move input generation for copy benchmark to device #10279
rapids-bot
merged 3 commits into
rapidsai:branch-22.04
from
karthikeyann:fea-benchmark_speedup_2.3
Feb 17, 2022
+13
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
approved these changes
Feb 14, 2022
ttnghia
reviewed
Feb 14, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10279 +/- ##
================================================
+ Coverage 10.42% 10.63% +0.21%
================================================
Files 119 122 +3
Lines 20603 20940 +337
================================================
+ Hits 2148 2228 +80
- Misses 18455 18712 +257
Continue to review full report at Codecov.
|
rerun tests |
davidwendt
reviewed
Feb 16, 2022
davidwendt
approved these changes
Feb 17, 2022
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 22, 2022
To speedup generate benchmark input generation, move all data generation to device. To address #5773 (comment) This PR moves the random input generation to device. Rest all of the original work in this PR was split to multiple PRs and merged. #10277 #10278 #10279 #10280 #10281 #10300 With all of these changes, single iteration of all benchmark runs in <1000 seconds. (from 3067s to 964s). Running more iterations would see higher benefit too because the benchmark is restarted several times during run which again calls benchmark input generation code. closes #9857 Authors: - Karthikeyan (https://github.com/karthikeyann) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Vukasin Milovanovic (https://github.com/vuule) - David Wendt (https://github.com/davidwendt) URL: #10109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
4 - Needs Review
Waiting for reviewer to review or respond
CMake
CMake build issue
feature request
New feature or request
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Performance
Performance related issue
tests
Unit testing for project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use device functions to move input generation to device in copy benchmark.
Splitting PR #10109 for review