device input generation in join bench #10277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikeyann
added
feature request
karthikeyann
removed
the
improvement
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10277 +/- ##
================================================
- Coverage 10.67% 10.67% -0.01%
================================================
Files 122 122
Lines 20873 20878 +5
================================================
Hits 2228 2228
- Misses 18645 18650 +5
Continue to review full report at Codecov.
|
devavret
approved these changes
Feb 14, 2022
PointKernel
reviewed
Feb 14, 2022
cpp/benchmarks/join/join_common.hpp
Outdated
| @@ -20,9 +20,14 @@ | |||
| #include <nvbench/nvbench.cuh> | |||
There was a problem hiding this comment.
According to https://github.com/rapidsai/cudf/blob/branch-22.04/cpp/docs/DEVELOPER_GUIDE.md#includes, headers should be included from the nearest to farthest.
vyasr
approved these changes
Feb 14, 2022
|
rerun tests |
karthikeyann
added
5 - Ready to Merge
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 22, 2022
To speedup generate benchmark input generation, move all data generation to device. To address #5773 (comment) This PR moves the random input generation to device. Rest all of the original work in this PR was split to multiple PRs and merged. #10277 #10278 #10279 #10280 #10281 #10300 With all of these changes, single iteration of all benchmark runs in <1000 seconds. (from 3067s to 964s). Running more iterations would see higher benefit too because the benchmark is restarted several times during run which again calls benchmark input generation code. closes #9857 Authors: - Karthikeyan (https://github.com/karthikeyann) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Vukasin Milovanovic (https://github.com/vuule) - David Wendt (https://github.com/davidwendt) URL: #10109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use device functions to move input generation to device in join benchmark.
Splitting PR #10109 for review