-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix out-of-memory error in compiled-binaryop benchmark #10269
Fix out-of-memory error in compiled-binaryop benchmark #10269
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10269 +/- ##
=============================================
Coverage 10.43% 10.43%
=============================================
Files 122 122
Lines 20583 20583
=============================================
Hits 2147 2147
Misses 18436 18436 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. TIL.
I too fixed the same bug locally with same fix.
Still unsure how this is caused. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@gpucibot merge |
Fixes out-of-memory error that occurs when running the
BINARYOP_BENCH
COMPILED_BINARYOP
benchmark combined with theBINARYOP
benchmark. The following minimal command shows the error:The
COMPILED_BINARYOP
is using aTEMPLATED_BENCHMARK_F
macro which causes a new separate memory pool to be created instead of reusing the one already created byBINARYOP
.This PR reworks the benchmark macros in
compiled_binaryop.cpp
to avoid usingTEMPLATED_BENCHMARK_F
allowing it share the existing memory pool.Similar to #10258