Fix out-of-memory error in UrlDecode benchmark #10258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10258 +/- ##
=============================================
Coverage 10.42% 10.43%
=============================================
Files 119 122 +3
Lines 20603 20583 -20
=============================================
- Hits 2148 2147 -1
+ Misses 18455 18436 -19
Continue to review full report at Codecov.
|
nvdbaranec
approved these changes
Feb 10, 2022
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 14, 2022
Fixes out-of-memory error that occurs when running the `BINARYOP_BENCH` `COMPILED_BINARYOP` benchmark combined with the `BINARYOP` benchmark. The following minimal command shows the error: ``` benchmarks/BINARYOP_BENCH '--benchmark_filter=COMPILED_BINARYOP|100000000/10' ... BINARYOP<double, TreeType::IMBALANCED_LEFT, false>/binaryop_double_imbalanced_unique/100000000/10/manual_time 40.4 ms 40.4 ms 17 bytes_per_second=202.953G/s terminate called after throwing an instance of 'rmm::out_of_memory' what(): std::bad_alloc: out_of_memory: RMM failure at:/conda/envs/rapids/include/rmm/mr/device/pool_memory_resource.hpp:192: Maximum pool size exceeded Aborted (core dumped) ``` The `COMPILED_BINARYOP` is using a `TEMPLATED_BENCHMARK_F` macro which causes a new separate memory pool to be created instead of reusing the one already created by `BINARYOP`. This PR reworks the benchmark macros in `compiled_binaryop.cpp` to avoid using `TEMPLATED_BENCHMARK_F` allowing it share the existing memory pool. Similar to #10258 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Nghia Truong (https://github.com/ttnghia) - MithunR (https://github.com/mythrocks) - Karthikeyan (https://github.com/karthikeyann) URL: #10269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes out-of-memory error that occurs when running the
STRINGS_BENCHUrlDecodebenchmark combined with any other benchmark. The following minimal command shows the error:The
UrlDecodeis the only benchmark in theSTRINGS_BENCHusing aTEMPLATED_BENCHMARK_Fwhich causes a new separate memory pool to be created instead of reusing the one already created from the previous benchmark.This PR reworks the benchmark macros in
url_decode.cppto avoid usingTEMPLATED_BENCHMARK_Fwhich fixes the issue.