Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix decimal metadata in parquet writer #10224

Merged
merged 1 commit into from
Feb 4, 2022
Merged

[REVIEW] Fix decimal metadata in parquet writer #10224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/cudf/cudf/_lib/utils.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2020-2021, NVIDIA CORPORATION.
# Copyright (c) 2020-2022, NVIDIA CORPORATION.

import numpy as np
import pyarrow as pa
Expand Down Expand Up @@ -190,6 +190,7 @@ cpdef generate_pandas_metadata(table, index):
col_meta["name"] in table._column_names
and table._data[col_meta["name"]].nullable
and col_meta["numpy_type"] in PARQUET_META_TYPE_MAP
and col_meta["pandas_type"] != "decimal"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually better

):
col_meta["numpy_type"] = PARQUET_META_TYPE_MAP[
col_meta["numpy_type"]
Expand Down
15 changes: 7 additions & 8 deletions python/cudf/cudf/tests/test_parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2265,18 +2265,17 @@ def test_parquet_writer_nested(tmpdir, data):
"decimal_type",
[cudf.Decimal32Dtype, cudf.Decimal64Dtype, cudf.Decimal128Dtype],
)
def test_parquet_writer_decimal(tmpdir, decimal_type):

gdf = cudf.DataFrame({"val": [0.00, 0.01, 0.02]})
@pytest.mark.parametrize("data", [[1, 2, 3], [0.00, 0.01, None, 0.5]])
def test_parquet_writer_decimal(decimal_type, data):
gdf = cudf.DataFrame({"val": data})

gdf["dec_val"] = gdf["val"].astype(decimal_type(7, 2))

fname = tmpdir.join("test_parquet_writer_decimal.parquet")
gdf.to_parquet(fname)
assert os.path.exists(fname)
buff = BytesIO()
gdf.to_parquet(buff)

got = pd.read_parquet(fname)
assert_eq(gdf, got)
got = pd.read_parquet(buff, use_nullable_dtypes=True)
assert_eq(gdf.to_pandas(nullable=True), got)


def test_parquet_writer_column_validation():
Expand Down