[REVIEW] Fix decimal metadata in parquet writer
#10224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
3 - Ready for Review
brandon-b-miller
approved these changes
Feb 4, 2022
devavret
approved these changes
Feb 4, 2022
| @@ -190,6 +190,7 @@ cpdef generate_pandas_metadata(table, index): | |||
| col_meta["name"] in table._column_names | |||
| and table._data[col_meta["name"]].nullable | |||
| and col_meta["numpy_type"] in PARQUET_META_TYPE_MAP | |||
| and col_meta["pandas_type"] != "decimal" | |||
galipremsagar
added
5 - Ready to Merge
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10224 +/- ##
================================================
+ Coverage 10.42% 10.47% +0.05%
================================================
Files 119 122 +3
Lines 20603 20487 -116
================================================
- Hits 2148 2147 -1
+ Misses 18455 18340 -115
Continue to review full report at Codecov.
|
|
@gpucibot merge |
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10172
pa.pandas_compat.construct_metadataconstructs the correct metadata but is being overridden by speciallist&structhandling logic asstring, rather than retaining it asobject. This PR fixes the issue and modifies existing tests to validate the issue.