Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a leftover _has_nulls change from Nullate #10211

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Fix a leftover _has_nulls change from Nullate #10211

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0f21dc
Fix a leftover _has_nulls change from Nullate
devavret Feb 3, 2022
9aec9ab
Another bug in default value of null_equality
devavret Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/include/cudf/table/row_operators.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ class element_hasher_with_seed {
template <typename T, CUDF_ENABLE_IF(column_device_view::has_element_accessor<T>())>
__device__ hash_value_type operator()(column_device_view col, size_type row_index) const
{
if (has_nulls && col.is_null(row_index)) { return _null_hash; }
if (_has_nulls && col.is_null(row_index)) { return _null_hash; }
return hash_function<T>{_seed}(col.element<T>(row_index));
}

Expand Down