Fix a leftover _has_nulls change from Nullate

[devavret]

There was one missed change from template param has_nulls to member Nullate _has_nulls. It worked because has_nulls resolved to pointer to the function has_nulls(table_view) which is always true and didn't break at runtime because the subsequent is_null has a built in nullmask check.

[davidwendt]

That's amazing. Good catch Devavret.
Don't forget to change the copyright.

[devavret]

One more small fix in default value of null_equality. This one should've broken because null_equality::EQUAL is 0 but true is 1.

[rgsl888prabhu]

One more small fix in default value of null_equality. This one should've broken because null_equality::EQUAL is 0 but true is 1.

In few minutes you might find one more :)

[hyperbolic2346]

Nice find

[codecov]

Codecov Report

Merging #10211 (9aec9ab) into branch-22.04 (a7d88cd) will increase coverage by 0.05%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           branch-22.04   #10211      +/-   ##
================================================
+ Coverage         10.42%   10.47%   +0.05%     
================================================
  Files               119      122       +3     
  Lines             20603    20501     -102     
================================================
  Hits               2148     2148              
+ Misses            18455    18353     -102     

Impacted Files	Coverage Δ
python/cudf/cudf/core/_base_index.py	0.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py	0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py	0.00% <0.00%> (ø)
python/cudf/cudf/core/column/datetime.py	0.00% <ø> (ø)
python/cudf/cudf/core/column/numerical.py	0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py	0.00% <ø> (ø)
python/cudf/cudf/core/column/timedelta.py	0.00% <0.00%> (ø)
python/cudf/cudf/core/column_accessor.py	0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py	0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py	0.00% <0.00%> (ø)
... and 17 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fbd797...9aec9ab. Read the comment docs.

[davidwendt]

So I hit this kind of thing when introducing the nullate type. Actually one of the motivations for coming up with this name was due to many name-collisions with the existing has_nulls in the repo. Given that I missed one (or more perhaps) without a compile error, I think it would be good to turn cudf::has_nulls(cudf::table_view) into a member function on cudf::table_view instead.
I can also see a similar error occuring with cudf::nullable(cudf::table_view)

[devavret]

I think it would be good to turn cudf::has_nulls(cudf::table_view) into a member function on cudf::table_view instead.

Should I do that in this PR?

[davidwendt]

I think it would be good to turn cudf::has_nulls(cudf::table_view) into a member function on cudf::table_view instead.

Should I do that in this PR?

There are over 40 places that cudf::has_nulls(table_view) is being used so I think a separate PR would be better.
Also, we may want to get other opinions on converting this into a member function independent of this fix.

[devavret]

@gpucibot merge