Remove unnecessary docker files. #10069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
3 - Ready for Review
|
Temporarily blocking merge until we get confirmation that it's OK to remove |
|
rerun tests |
2 similar comments
|
rerun tests |
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10069 +/- ##
===============================================
Coverage ? 10.42%
===============================================
Files ? 119
Lines ? 20607
Branches ? 0
===============================================
Hits ? 2148
Misses ? 18459
Partials ? 0 Continue to review full report at Codecov.
|
|
@gpucibot merge |
Merged
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 22, 2022
This PR removes the outdated files `.dockerignore` and `MANIFEST.in`. The Dockerfile was removed in #10069 so we don't need to keep the ignore file around anymore. The `MANIFEST.in` is very old (last updated in 2018, cad899b) and no longer correct for the current package structure. Finally, I moved `.clang-tidy` into the `cpp/` directory. @codereport said that would be fine to clean up from the root and have no negative effects since clang-tidy isn't being run yet. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Karthikeyan (https://github.com/karthikeyann) - AJ Schmidt (https://github.com/ajschmidt8) URL: #11124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes docker-related files that are no longer necessary.