Skip to content

Commit

Permalink
Clean up repo root (#11124)
Browse files Browse the repository at this point in the history
This PR removes the outdated files `.dockerignore` and `MANIFEST.in`. The Dockerfile was removed in #10069 so we don't need to keep the ignore file around anymore. The `MANIFEST.in` is very old (last updated in 2018, cad899b) and no longer correct for the current package structure.

Finally, I moved `.clang-tidy` into the `cpp/` directory. @codereport said that would be fine to clean up from the root and have no negative effects since clang-tidy isn't being run yet.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Karthikeyan (https://github.com/karthikeyann)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #11124
  • Loading branch information
bdice authored Jun 22, 2022
1 parent e3d3df3 commit b250ac7
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 9 deletions.
2 changes: 0 additions & 2 deletions .dockerignore

This file was deleted.

3 changes: 0 additions & 3 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,3 @@ java/ @rapidsai/cudf-java-codeowners
.github/ @rapidsai/ops-codeowners
/ci/ @rapidsai/ops-codeowners
conda/ @rapidsai/ops-codeowners
/Dockerfile @rapidsai/ops-codeowners
/.dockerignore @rapidsai/ops-codeowners
/docker/ @rapidsai/ops-codeowners
2 changes: 0 additions & 2 deletions MANIFEST.in

This file was deleted.

4 changes: 2 additions & 2 deletions .clang-tidy → cpp/.clang-tidy
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
---
Checks:
Checks:
'modernize-*,
-modernize-use-equals-default,
-modernize-concat-nested-namespaces,
-modernize-use-trailing-return-type'

# -modernize-use-equals-default # auto-fix is broken (doesn't insert =default correctly)
# -modernize-concat-nested-namespaces # auto-fix is broken (can delete code)
# -modernize-use-trailing-return-type # just a preference
Expand Down

0 comments on commit b250ac7

Please sign in to comment.