[FEA] Cleanup on logic inside DeviceRolling::is_supported()

[nvdbaranec]

There is some logic in

cudf/cpp/src/rolling/rolling_detail.cuh

Line 82 in 0eeb0c9

static constexpr bool is_supported()

that really should be covered by is_valid_aggregation, but is_valid_aggregation is currently missing some edge cases.

 // MIN/MAX supports all fixed width types
 (((O == aggregation::MIN || O == aggregation::MAX) && cudf::is_fixed_width<T>()) ||

  // SUM supports all fixed width types except timestamps
  ((O == aggregation::SUM) && (cudf::is_fixed_width<T>() && !cudf::is_timestamp<T>())) ||

  // MEAN supports numeric and duration
  ((O == aggregation::MEAN) && (cudf::is_numeric<T>() || cudf::is_duration<T>())));

Once these edge cases are cleared up, clear out this code. Also, if is_valid_aggregation can handle a wide enough set of cases, it might be possible to remove the various is_supported() functions entirely and just have a single generic global template (checking is_valid_aggregation and has_corresponding_operator) used in it's place.

[nvdbaranec]

Pinging @mythrocks

[github-actions]

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

[bdice]

@mythrocks @karthikeyann This came up in our meeting today. If you have any additional context on what needs to be done or whether this issue can be closed, feel free to share. The code has moved to a different filename since this issue was filed:

cudf/cpp/src/rolling/detail/rolling.cuh

Line 83 in 3bf6d1d

static constexpr bool is_supported()

[mythrocks]

There is some cleanup that can be done here, but I don't know if there's enough to warrant a pair-up.
At the time, is_valid_aggregation() returned incorrect results for STRUCT/LIST. E.g. SUM on STRUCT columns. I haven't checked if that's been sorted out. If it has, then is_valid_aggregation() can be used in place of DeviceRolling::is_supported().