Skip to content

Commit

Permalink
Fix SUM/MEAN aggregation type support. (#12503)
Browse files Browse the repository at this point in the history
This PR closes #8399. We cleaned up the logic by fixing SUM/MEAN aggregation type support, which also eliminated `TODO` comments in the target type definitions.

We kept the restriction that rolling min/max requires fixed width types because min/max aggregations do support non-fixed width in other aggregation implementations (groupby does a argmin-and-gather approach on strings, for instance).

This PR is collaborative work with @karthikeyann.

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Karthikeyan (https://github.com/karthikeyann)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - David Wendt (https://github.com/davidwendt)

URL: #12503
  • Loading branch information
bdice authored Jan 24, 2023
1 parent 2bcdb54 commit ed6daad
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit ed6daad

Please sign in to comment.