-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Series unique should return an array rather than a dataframe #8175
Comments
Hmm, this is problematic for us in handling things like strings or decimal values which can't be supported by arrays as of now. @shwina is scoping building |
This issue has been labeled |
Partially addresses #8175 This PR makes changes to `Series.unique`, where a cupy array is returned to match `pd.Series.unique` where a numpy array is returned. Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Lawrence Mitchell (https://github.com/wence-) URL: #13959
I'm not sure what we should do about this. I don't think extension arrays are on our roadmap for any time soon. @galipremsagar WDYT? We could match the type for types supported by cupy, but returning a different object based on the data type seems even worse than the status quo. Fundamentally I don't know that we'll ever be able to solve this since we have other types that cupy will probably never support (list and struct, for instance). |
Pandas's unique method returns an array, while ours returns a Series.
The text was updated successfully, but these errors were encountered: