Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QST] Should cudf.Series.unique return a ndarray or cudf.Series? #16461

Closed
Matt711 opened this issue Aug 1, 2024 · 2 comments
Closed

[QST] Should cudf.Series.unique return a ndarray or cudf.Series? #16461

Matt711 opened this issue Aug 1, 2024 · 2 comments
Labels
question Further information is requested

Comments

@Matt711
Copy link
Contributor

Matt711 commented Aug 1, 2024

What is your question?
Should cudf.Series.unique return a ndarray or cudf.Series? I'll change this issue if this is a bug.

In [1]: import pandas as pd

In [2]: import cudf

In [3]: type(pd.Series([2,1,3,3]).unique())
Out[3]: numpy.ndarray

In [4]: type(cudf.Series([2,1,3,3]).unique())
Out[4]: cudf.core.series.Series

In [5]: type(pd.unique(pd.Series([2,1,3,3])))
Out[5]: numpy.ndarray
@Matt711 Matt711 added the question Further information is requested label Aug 1, 2024
@davidwendt
Copy link
Contributor

davidwendt commented Aug 1, 2024

I believe this came up recently here: #16417
And not so recently here: #8175

@bdice
Copy link
Contributor

bdice commented Aug 1, 2024

Note that we return a cupy array when cudf.pandas is enabled. (Also discussed in those linked issues.)

@Matt711 Matt711 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants