Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] JNI: Support creating a null list scalar with the correct nested empty column inside. #8170

Closed
firestarman opened this issue May 6, 2021 · 1 comment · Fixed by #8173
Closed

[FEA] JNI: Support creating a null list scalar with the correct nested empty column inside. #8170

firestarman opened this issue May 6, 2021 · 1 comment · Fixed by #8173
Labels
feature request New feature or request Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS

Comments

@firestarman
Copy link
Contributor

firestarman commented May 6, 2021 •
edited
Loading

Besides setting the validity flag to false, we still need to create an empty column with the correct children for it, instead of the default column created by cpp.
@firestarman firestarman added feature request New feature or request Needs Triage Need team to review and classify labels May 6, 2021
@firestarman firestarman mentioned this issue May 6, 2021
Merged
@jlowe jlowe added Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS and removed Needs Triage Need team to review and classify labels May 6, 2021
@jlowe
Copy link
Member

jlowe commented May 6, 2021

Duplicate of #8140?

@rapids-bot rapids-bot bot closed this as completed in #8173 May 8, 2021
rapids-bot bot pushed a commit that referenced this issue May 8, 2021
@firestarman
Creates an empty column for the null LIST Scalar (#8173)
3813d9b 
This PR is to support creating a null `LIST Scalar` with an empty column but containing all the necessary children, from a `HostColumnVector.DataType`.

Also removed the function `cudf::jni::make_empty_column`, which is a duplicate of `cudf::empty_like`. and replaced it with the `cudf::empty_like` when building a column from a list scalar. 

closes #8170

Signed-off-by: Firestarman <[email protected]>

Authors:
  - Liangcai Li (https://github.com/firestarman)

Approvers:
  - Robert (Bobby) Evans (https://github.com/revans2)
  - Jason Lowe (https://github.com/jlowe)

URL: #8173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Creates an empty column for the null LIST Scalar [skip ci] firestarman/cudf
2 participants
@jlowe @firestarman