Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Java Scalar.fromNull returns untyped list column #8140

Closed
revans2 opened this issue May 3, 2021 · 1 comment
Closed

[BUG] Java Scalar.fromNull returns untyped list column #8140

revans2 opened this issue May 3, 2021 · 1 comment
Assignees
@gerashegalov
Labels
bug Something isn't working Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS

Comments

@revans2
Copy link
Contributor

revans2 commented May 3, 2021

Describe the bug
The existing java Scalar API for nulls fromNull returns an incomplete typed scalar for lists. fromNull only takes a DType to try and construct a null scalar, but for nested types a DType does not describe enough information. A LIST of STRING is very different from a LIST of INT32. The on device buffers are not different, but the metadata on the CPU is. That information is lost when creating the scalar. We really should just throw an exception in these cases. Instead we should have listFromColumnView check to see if the single row is null or not and go off of that instead.
@revans2 revans2 added bug Something isn't working Needs Triage Need team to review and classify Java Affects Java cuDF API. labels May 3, 2021
@jlowe jlowe changed the title [BUG] [BUG] Java Scalar.fromNull returns untyped list column May 3, 2021
@jlowe jlowe added Spark Functionality that helps Spark RAPIDS and removed Needs Triage Need team to review and classify labels May 3, 2021
@gerashegalov gerashegalov self-assigned this May 3, 2021
@jlowe jlowe mentioned this issue May 6, 2021
Closed
@jlowe
Copy link
Member

jlowe commented May 10, 2021

This should be handled by #8173.

@jlowe jlowe closed this as completed May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerashegalov gerashegalov

Labels
bug Something isn't working Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlowe @gerashegalov @revans2