Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] cudf::lists::sort_lists fails for sliced column #7530

Closed
ttnghia opened this issue Mar 8, 2021 · 1 comment · Fixed by #7564
Closed

[BUG] cudf::lists::sort_lists fails for sliced column #7530

ttnghia opened this issue Mar 8, 2021 · 1 comment · Fixed by #7564
Labels
0 - Blocked Cannot progress due to external reasons bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.

Comments

@ttnghia
Copy link
Contributor

ttnghia commented Mar 8, 2021 •
edited
Loading

Describe the bug
The list sort API cudf::lists::sort_lists fails for the following test case:

using int_type   = int32_t;
using INT_LCW    = cudf::test::lists_column_wrapper<int_type>;

auto list0 = INT_LCW{{1, 2, 3, 2, 3, 2, 3, 2, 3}, {3, 2, 1, 4, 1}, {5}, {10, 8, 9}, {6, 7}};
auto list1 = cudf::slice(list0, {1, 3})[0];

auto l = cudf::lists::sort_lists(list1, cudf::order::ASCENDING, cudf::null_order::AFTER);

Error message:

unknown file: Failure
C++ exception with description "cuDF failure at: .../cpp/src/lists/lists_column_factories.cu:36: 
Invalid offsets column size for lists column."

To clarify, sort_lists fails for sliced columns (like cudf::slice(list0, {1, 3})[0] in the example above).
@ttnghia ttnghia added bug Something isn't working Needs Triage Need team to review and classify labels Mar 8, 2021
@ttnghia ttnghia added the libcudf Affects libcudf (C++/CUDA) code. label Mar 8, 2021
@ttnghia ttnghia mentioned this issue Mar 8, 2021
Merged
@ttnghia ttnghia added 0 - Blocked Cannot progress due to external reasons libcudf blocker labels Mar 8, 2021
@ttnghia
Copy link
Contributor Author

ttnghia commented Mar 8, 2021 •
edited
Loading

Please note that I have other PR (#7528), which has a test depending on this. In other word, this bug blocks other PR.

@kkraus14 kkraus14 removed Needs Triage Need team to review and classify libcudf blocker labels Mar 9, 2021
@ttnghia ttnghia mentioned this issue Mar 10, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Mar 11, 2021
@ttnghia
Fix cudf::lists::sort_lists failing for sliced column (#7564)
eaec3db 
This fixes #7530 (`cudf::lists::sort_lists` fails for sliced column). 

I also added more tests for sliced columns to cover the previously failed cases, and added a header `lists/detail/sorting.cuh` to expose the internal `detail::sort_lists` API which accepts a stream parameter.

Authors:
  - Nghia Truong (@ttnghia)

Approvers:
  - David (@davidwendt)
  - AJ Schmidt (@ajschmidt8)
  - Karthikeyan (@karthikeyann)

URL: #7564
hyperbolic2346 pushed a commit to hyperbolic2346/cudf that referenced this issue Mar 25, 2021
@ttnghia @hyperbolic2346
Fix cudf::lists::sort_lists failing for sliced column (rapidsai#7564)
b7dd2cd 
This fixes rapidsai#7530 (`cudf::lists::sort_lists` fails for sliced column). 

I also added more tests for sliced columns to cover the previously failed cases, and added a header `lists/detail/sorting.cuh` to expose the internal `detail::sort_lists` API which accepts a stream parameter.

Authors:
  - Nghia Truong (@ttnghia)

Approvers:
  - David (@davidwendt)
  - AJ Schmidt (@ajschmidt8)
  - Karthikeyan (@karthikeyann)

URL: rapidsai#7564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - Blocked Cannot progress due to external reasons bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix cudf::lists::sort_lists failing for sliced column ttnghia/cudf
2 participants
@kkraus14 @ttnghia