Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]Implement Series.datetime.floor #7102

Closed
VibhuJawa opened this issue Jan 8, 2021 · 4 comments · Fixed by #9488 or #9571
Closed

[FEA]Implement Series.datetime.floor #7102

VibhuJawa opened this issue Jan 8, 2021 · 4 comments · Fixed by #9488 or #9571
Assignees
@mayankanand007 @skirui-source
Labels
feature request New feature or request Python Affects Python cuDF API.
Milestone
Time Series Analysis

Comments

@VibhuJawa
Copy link
Member

Is your feature request related to a problem? Please describe.
We should implement Series.dt.floor following the pandas API.

Describe the solution you'd like
It should follow the pandas dt.floor API.

Additional context
The current need for this feature comes from the current integration work with featuretools.
@VibhuJawa VibhuJawa added feature request New feature or request Needs Triage Need team to review and classify labels Jan 8, 2021
@kkraus14 kkraus14 added Python Affects Python cuDF API. and removed Needs Triage Need team to review and classify labels Jan 8, 2021
@shwina
Copy link
Contributor

shwina commented Jan 8, 2021

@brandon-b-miller and I are running into this as part of extending cudf.DateOffset. It looks like this may need some libcudf support, which in turn would use something like https://en.cppreference.com/w/cpp/chrono/time_point/floor.

This was referenced Jan 11, 2021
Closed
Merged
Closed
@github-actions
Copy link

This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.

@github-actions github-actions bot added the stale label Feb 16, 2021
@shwina
Copy link
Contributor

shwina commented Feb 16, 2021

DateOffset work ongoing in #7078. This will follow soon.

@github-actions github-actions bot removed the stale label Feb 16, 2021
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@brandon-b-miller brandon-b-miller mentioned this issue Apr 8, 2021
Open
@beckernick beckernick mentioned this issue Jul 7, 2021
Closed
@beckernick beckernick added this to the Time Series Analysis milestone Jul 14, 2021
@skirui-source skirui-source mentioned this issue Oct 21, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Oct 29, 2021
@skirui-source
Implement Series.datetime.floor (#9488)
201f750 
Fixes: #7102

Authors:
  - Sheilah Kirui (https://github.com/skirui-source)
  - Mayank Anand (https://github.com/mayankanand007)

Approvers:
  - Mike Wilson (https://github.com/hyperbolic2346)
  - Ashwin Srinath (https://github.com/shwina)
  - GALI PREM SAGAR (https://github.com/galipremsagar)

URL: #9488
@skirui-source skirui-source mentioned this issue Oct 30, 2021
Merged
@galipremsagar galipremsagar reopened this Nov 1, 2021
rapids-bot bot pushed a commit that referenced this issue Nov 17, 2021
@skirui-source
Implement Series.datetime.floor (#9571)
e08ae9c 
Fixes: #7102
Replaces: [#9488](https://github.com/rapidsai/cudf/pull/9488/files)

Authors:
  - Sheilah Kirui (https://github.com/skirui-source)
  - Mayank Anand (https://github.com/mayankanand007)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Michael Wang (https://github.com/isVoid)
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #9571
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mayankanand007 mayankanand007

@skirui-source skirui-source

Labels
feature request New feature or request Python Affects Python cuDF API.
Projects
None yet
Milestone
Time Series Analysis
8 participants
@shwina @kkraus14 @VibhuJawa @beckernick @galipremsagar @mayankanand007 @brandon-b-miller @skirui-source