[WIP]Add support for approx parameter with cutoff as pandas dataframes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VibhuJawa
added a commit
that referenced
this pull request
Jan 12, 2021
* inital experiments with negate * inital working with agg * added working agg stats * working+verified with agg columns * fixed fillna mistake * added back comment * decreased inconsitentcies * 2 percent incorrect left * Verified correctness across 2000 columns * Code cleanup * more cleanup * Added more primitives * 10/12 tests working * working test_add_last_time_indexes * working with most tests * removed test_debug.py * Major code cleanup * passes most tests * Create nvidia_featuretools_copyright.md Adding Nvidia license. * Update and rename nvidia_featuretools_copyright.md to nvidia_featuretools_license.md * Unpin graphviz on windows ci tests (alteryx#1296) * Unpin graphviz on windows ci tests * Update release_notes.rst * fixed test failures * remove unused cudf import from test_dfs_method.py * add cudf computational backend * Update latest_dependencies.txt (alteryx#1300) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [WIP]Add support for approx parameter with cutoff as pandas dataframes (#1) * working approx implementation with cutoff as a pandas dataframe. * style fix for comment at line :463 Co-authored-by: Roy Wedge <[email protected]> Co-authored-by: machineFL <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for approx parameter with cutoff as pandas dataframes
This pr adds support for approx parameter with the cutoffs as pandas dataframes .
See docs page for handling cutoff times.
This is useful for porting workflows that use this parameter like the https://github.com/Featuretools/predict-taxi-trip-duration/blob/master/NYC%20Taxi%203%20-%20Simple%20Featuretools.ipynb to cudf .
We cant support cudf DataFrame as input to cutoff frames as it will require rapidsai/cudf#7102 to work.
Null handling(Wont do because default value filling is not support for frames other than pandas frames, see: https://github.com/alteryx/featuretools/blob/34a5dac89bbb254e524a154270274dbf6060acc4/featuretools/computational_backends/feature_set_calculator.py#L125-L140)