Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional tests for cudf::distinct using the new row hasher #10742

Open
2 of 3 tasks
vyasr opened this issue Apr 26, 2022 · 2 comments
Open
2 of 3 tasks

Additional tests for cudf::distinct using the new row hasher #10742

vyasr opened this issue Apr 26, 2022 · 2 comments
Assignees
Labels
0 - Backlog In queue waiting for assignment improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. tests Unit testing for project

Comments

@vyasr
Copy link
Contributor

vyasr commented Apr 26, 2022

#10641 adds new a new row hasher capable of natively handling nested struct and list types. The new hasher was tested by incorporating it into the implementation of cudf::distinct. Now that the functionality for cudf::distinct has been expanded by the use of this new hasher, we should add tests for some new cases, as was pointed out in some discussion threads on that PR:

Adding these tests will be helpful to validate the behavior of the new row hasher.

@vyasr
Copy link
Contributor Author

vyasr commented Apr 26, 2022

@ttnghia I've assigned you since you made this request, but feel free to change that if necessary.

@vyasr vyasr changed the title Add tests of cudf::distinct with sliced struct/list input Additional tests for cudf::distinct using the new row hasher Apr 26, 2022
@vyasr
Copy link
Contributor Author

vyasr commented Apr 26, 2022

@bdice I've updated the issue to include some of your testing requests and assigned you as well.

@vyasr vyasr added 0 - Backlog In queue waiting for assignment tests Unit testing for project code quality libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function labels Apr 26, 2022
rapids-bot bot pushed a commit that referenced this issue May 16, 2022
… input (#10860)

This adds more nested types tests for `cudf::distinct`, including cases of `List<Struct<...>>` and `Struct<List<...>>`, and the input columns are sliced.

Partially addresses #10742.

Authors:
  - Nghia Truong (https://github.com/ttnghia)

Approvers:
  - Karthikeyan (https://github.com/karthikeyann)
  - David Wendt (https://github.com/davidwendt)

URL: #10860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - Backlog In queue waiting for assignment improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. tests Unit testing for project
Projects
None yet
Development

No branches or pull requests

3 participants