Additional tests for cudf::distinct using the new row hasher #10742
Labels
0 - Backlog
In queue waiting for assignment
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
tests
Unit testing for project
#10641 adds new a new row hasher capable of natively handling nested struct and list types. The new hasher was tested by incorporating it into the implementation of
cudf::distinct
. Now that the functionality forcudf::distinct
has been expanded by the use of this new hasher, we should add tests for some new cases, as was pointed out in some discussion threads on that PR:List<Struct<...>>
andStruct<List<...>>
to ensure that the new nesting behavior really works as expected (Add row hasher with nested column support #10641 (comment))List<List<Struct<List<...>>>>
) to potentially help catch unexpected errors (Add row hasher with nested column support #10641 (comment))Adding these tests will be helpful to validate the behavior of the new row hasher.
The text was updated successfully, but these errors were encountered: