address reviews

rapidsai · Nov 9, 2022 · 302fe60 · 302fe60
1 parent 837a49c
commit 302fe60
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/python/cudf/cudf/core/udf/strings_typing.py b/python/cudf/cudf/core/udf/strings_typing.py
@@ -13,7 +13,7 @@
     id_unary_funcs,
     int_binary_funcs,
     size_type,
-    string_binary_funcs,
+    string_return_attrs,
     string_view,
     udf_string,
 )
@@ -174,7 +174,7 @@ def resolve_valid(self, mod):
         create_masked_binary_attr(f"MaskedType.{func}", size_type),
     )
 
-for func in string_binary_funcs:
+for func in string_return_attrs:
     setattr(
         MaskedStringViewAttrs,
         f"resolve_{func}",

diff --git a/python/cudf/cudf/tests/test_udf_masked_ops.py b/python/cudf/cudf/tests/test_udf_masked_ops.py
@@ -876,6 +876,7 @@ def func(row):
     run_masked_udf_test(func, str_udf_data, check_dtype=False)
 
 
+@string_udf_test
 @pytest.mark.parametrize("strip_char", ["1", "a", "12", " ", "", ".", "@"])
 def test_string_udf_strip(str_udf_data, strip_char):
     def func(row):
@@ -884,6 +885,7 @@ def func(row):
     run_masked_udf_test(func, str_udf_data, check_dtype=False)
 
 
+@string_udf_test
 @pytest.mark.parametrize("strip_char", ["1", "a", "12", " ", "", ".", "@"])
 def test_string_udf_lstrip(str_udf_data, strip_char):
     def func(row):
@@ -892,6 +894,7 @@ def func(row):
     run_masked_udf_test(func, str_udf_data, check_dtype=False)
 
 
+@string_udf_test
 @pytest.mark.parametrize("strip_char", ["1", "a", "12", " ", "", ".", "@"])
 def test_string_udf_rstrip(str_udf_data, strip_char):
     def func(row):

diff --git a/python/strings_udf/strings_udf/_typing.py b/python/strings_udf/strings_udf/_typing.py
@@ -229,7 +229,7 @@ def resolve_count(self, mod):
     "isnumeric",
     "istitle",
 ]
-string_binary_funcs = ["strip", "lstrip", "rstrip"]
+string_return_attrs = ["strip", "lstrip", "rstrip"]
 
 for func in bool_binary_funcs:
     setattr(
@@ -238,7 +238,7 @@ def resolve_count(self, mod):
         create_binary_attr(func, types.boolean),
     )
 
-for func in string_binary_funcs:
+for func in string_return_attrs:
     setattr(
         StringViewAttrs,
         f"resolve_{func}",