Skip to content

Commit

Permalink
Update python/strings_udf/strings_udf/lowering.py
Browse files Browse the repository at this point in the history
Co-authored-by: Vyas Ramasubramani <[email protected]>
  • Loading branch information
brandon-b-miller and vyasr authored Nov 9, 2022
1 parent 9991c76 commit 837a49c
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion python/strings_udf/strings_udf/lowering.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,11 @@ def binary_func_impl(context, builder, sig, args):
# binary function of two strings yielding a new string
# example: str.strip(other) -> str
# shim functions can not return a struct due to C linkage
# so we operate on an extra void ptr and throw away nb_retval
# so we create a new udf_string and pass a pointer to it
# for the shim function to write the output to. The return
# value of compile_internal is therefore discarded (although
# this may change in the future if we need to return error
# codes, for instance).
udf_str_ptr = builder.alloca(
default_manager[udf_string].get_value_type()
)
Expand Down

0 comments on commit 837a49c

Please sign in to comment.