Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-conda: update environment earlier #186

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Sep 3, 2024

Fixes #185

#185 (comment) has MUCH more detail, but in short:

  • the way we build ci-conda images results in symlinks from libdstc++.so to the fully-qualified libstdc++.so.6.0.33 (or similar) being destroyed
  • that results in the system libdstc++ being used instead of conda's
  • that results in issues about missing GLIBCXX symbols (in the case where the system one is older than the one used at build time for libraries conda wants to load)

This PR is a hack to unblock CI... by manually recreating those symlinks where necessary.

Updated this to @vyasr 's suggestion from #185 (comment)

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Sep 3, 2024
@jameslamb jameslamb changed the title WIP: manually recreate libstdc++ symlinks in ci-conda images manually recreate libstdc++ symlinks in ci-conda images Sep 3, 2024
@jameslamb jameslamb marked this pull request as ready for review September 3, 2024 22:38
@jameslamb jameslamb requested a review from a team as a code owner September 3, 2024 22:38
@jameslamb jameslamb requested review from AyodeAwe and msarahan and removed request for a team September 3, 2024 22:38
@jameslamb jameslamb assigned jameslamb and msarahan and unassigned jameslamb Sep 3, 2024
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to propose an alternate, hopefully more robust solution to the problem. I posted it on the issue.

@jameslamb jameslamb changed the title manually recreate libstdc++ symlinks in ci-conda images ci-conda: update environment earlier Sep 4, 2024
@jameslamb jameslamb requested a review from vyasr September 4, 2024 14:18
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo otherwise LGTM.

Co-authored-by: Vyas Ramasubramani <[email protected]>
@jameslamb jameslamb merged commit 1aa5d8c into rapidsai:main Sep 4, 2024
434 checks passed
@jameslamb jameslamb deleted the ci/fix-glibcxx-issues branch September 4, 2024 19:13
rapids-bot bot pushed a commit to rapidsai/docker that referenced this pull request Sep 6, 2024
Nightly builds of `rapidsai/raft-ann-bench` failed like this:

> ImportError: /lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.32' not found (required by /opt/conda/lib/python3.11/site-packages/libmambapy/bindings.cpython-311-aarch64-linux-gnu.so)

([build link](https://github.com/rapidsai/docker/actions/runs/10739898324/job/29789780257))

I suspect that's because those images use the same pattern for initializing a conda environment that led to the issues described in rapidsai/ci-imgs#185.

This proposes the same fix that we applied in `ci-imgs` (rapidsai/ci-imgs#186).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Mike Sarahan (https://github.com/msarahan)

URL: #710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci-conda builds failing with GLIBCXX errors
4 participants