Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.9 back temporarily for a 24.08 hotfix #184

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

raydouglass
Copy link
Member

@raydouglass raydouglass commented Sep 3, 2024

We're planning one final hotfix for 24.08 which supports Python 3.9, so add it back here out an abundance of caution. Without this, the Python 3.9 builds will use outdated images.

This can undone in ~2 weeks.

@raydouglass raydouglass requested a review from a team as a code owner September 3, 2024 16:38
@raydouglass raydouglass requested review from msarahan and removed request for a team September 3, 2024 16:38
@jameslamb
Copy link
Member

Looks like you're running into the same ci-conda build issues I've been seeing on other PRs here this morning.

I'm tracking that in #185 and I'm using #183 to investigate.

@jameslamb
Copy link
Member

@raydouglass I put up a hack to temporarily fix CI in #186 . It could be merged to unblock CI here for the purposes of rolling out this 24.08 hotfix if you need something quick.

@raydouglass
Copy link
Member Author

@raydouglass I put up a hack to temporarily fix CI in #186 . It could be merged to unblock CI here for the purposes of rolling out this 24.08 hotfix if you need something quick.

Thanks @jameslamb! This is not urgent and can wait a couple days for a solution.

@jameslamb
Copy link
Member

Thanks @raydouglass ! We got #186 to a point where it now contains a long-term solution and not a hack 😁

Once I merge that to main, I'll update this PR and merge it for you if you'd like.

@jameslamb jameslamb merged commit 77ad010 into main Sep 4, 2024
577 checks passed
@jameslamb jameslamb deleted the 24.08-hotfix-python3.9 branch September 4, 2024 20:51
@jameslamb
Copy link
Member

Thanks for the review @msarahan !

@raydouglass I opened #187 to track the work of reverting this in a few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants