Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add icon for curbs of unspecified type #90

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

tyrasd
Copy link
Contributor

@tyrasd tyrasd commented Feb 27, 2024

This would be for openstreetmap/id-tagging-schema#1077

I chose the raised curb icon as the base for this, because I'd assume that that's the fallback most data consumers would choose, if the type of curb is nor mapped (it's probably safer to route a wheelchair user a longer route compared to getting them stuck at an unspecified curb). //edit: icon slightly updated after feedback in comment below)

As an alternative I had also played around with using stripes to indicate the unknown height of the curb, like this: Let me know if you'd prefer that one.

@tordans
Copy link

tordans commented Feb 28, 2024

In general I agree that a different icon would be great in this case.

A few thoughts on the "iconography"…

I wonder if it is a good idea to add symbols like the question mark as element to indicate unspecified elements … because if we start with that, it would ideally span to other cases as well. What other cases are there?

The second option would be more in line with what we have (AKA we don't use "letters" ATM), however I don't think its easy enough to understand out of context.

The ? in your version looks a bit too thing. I wonder if the (?) from Bryans Example in #87 (comment) would be a better fit instead?

@tyrasd
Copy link
Contributor Author

tyrasd commented Feb 28, 2024

Yeah… I was also not 100% happy with the question mark in the icon, that's why I played around with the shaded version. But I wasn't really happy with that one as well (for the reasons you identified).

I'm not a trained designer, so take this with a grain (or two) of salt:
Interestingly, the question mark seems to be an (arguably) almost "universally recognized" symbol. Only very few languages/scripts use different symbols for it (Greek is one example). At least compared to a few other symbols we use in the icon sets (e.g. the $ in car_dealer.svg). The question mark could be fine to represent a situation of unspecific state and/or the lack of knowledge of the mapper creating these objects.

@tyrasd
Copy link
Contributor Author

tyrasd commented Feb 28, 2024

The ? in your version looks a bit too thin

You're right. I don't know which font was used for the mockup in the tree issue exactly, but this might be better: (for comparison here it is next to the original one from this PR: ).

(based on font: Noto Sans 8px Semi-Bold)
@tyrasd
Copy link
Contributor Author

tyrasd commented Feb 28, 2024

What other cases are there?

For presets, I would recommend to only use a ? icon for very specific cases, e.g., if there is a "generic" preset for which an exhaustive list of specialized subpresets exists which can be considered to be preferable to be mapped.

The (hidden) presets for shop=yes, man_made=yes, traffic_calming=yes, etc. would be candidates to make them visually stand out on the map. Maybe also something like the amenity/parking preset.

@bhousel
Copy link
Collaborator

bhousel commented Feb 28, 2024

Without adding a better tag, iD just shows a dot. Isn't this ok?
I've always considered the dot as "some tag is here but it's not recognized".
This is the kind of signal we want to give the user to pick something better.

Screenshot 2024-02-28 at 9 04 10 AM

@tyrasd
Copy link
Contributor Author

tyrasd commented Feb 28, 2024

This icon would be for barrier=kerb, which is currently using temaki-kerb-raised as an icon, which is not ideal as it is doubling as the icon for the Raised Curb preset for which it was designed. Completely dropping the icon from the generic Curb preset would be an option, but in my opinion not the greatest.

@bhousel
Copy link
Collaborator

bhousel commented Mar 11, 2024

ok thanks, seems fine

@bhousel bhousel merged commit 0660a74 into rapideditor:main Mar 11, 2024
@tyrasd tyrasd deleted the kerb-unspecified branch March 13, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants