Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree types #87

Closed
bhousel opened this issue Aug 23, 2023 · 8 comments
Closed

Tree types #87

bhousel opened this issue Aug 23, 2023 · 8 comments

Comments

@bhousel
Copy link
Collaborator

bhousel commented Aug 23, 2023

The latest id-tagging-schema switched the tree icons to use the roentgen-tree icon
openstreetmap/id-tagging-schema#956

Screenshot 2023-08-23 at 2 36 37 PM

I don't think these look very good - so I'd like make sure all the leaf types have better icons in temaki, so we can override this.

https://wiki.openstreetmap.org/wiki/Key:leaf_type

  • broad leaved
  • needle leaved
  • leafless (aka cactus)
  • palm (apparently this got deprecated without any replacement and is still widely used?)
@tordans
Copy link

tordans commented Oct 9, 2023

Oh, I just wanted to suggest this.

Another great Icon would be a split-tree half broad leaved half needle leaved to to use as a "generic tree" for the base-preset of just natural=tree.

…so we can override this.

I am all for updating the existing preset.

palm (apparently this got deprecated without any replacement and is still widely used?)

Yeah, was confused by this but did not have the energy to dive into the topic. I hoped at some point someone would clarify the tagging in the wiki…

bhousel added a commit that referenced this issue Oct 19, 2023
bhousel added a commit that referenced this issue Oct 19, 2023
(re: #87)

These are just slightly cleaned up copies of maki-park and maki-park-alt1
bhousel added a commit that referenced this issue Oct 19, 2023
@bhousel
Copy link
Collaborator Author

bhousel commented Oct 19, 2023

I added some tree icons today! 🌳 🌵 🌲 🌴

The broadleaved and needleleaved ones are just slightly cleaned-up copies of the park icons already in maki, because I think they're fine as-is.

Screenshot 2023-10-19 at 4 14 06 PM

I'm going to close this for now, but will think of how we might do a "generic" tree preset..

I'm weakly against the idea of a "split-tree half broad leaved half needle leaved" icon, mostly because it would be a lot of work and not really look like any tree - it would look more like a mistake.

Maybe for generic presets, we could badge them with a ❓ or something:

Screenshot 2023-10-19 at 4 26 21 PM

@tordans
Copy link

tordans commented Oct 21, 2023

Thanks @bhousel those look good. However, I am not sure they will solve the current styling issue in iD/Rapid. I see the issue there as one with the "unspecified type". But we cannot update this preset with the broadleave icon since it will look the same as the more specific icon. And we need a solution for the map pin icon so the ?-badge would be a big(ger) change on that one. So for now I don't see a direct follow up to improve openstreetmap/id-tagging-schema#956 until we have a "unspecified" or half-half-tree.

Something like image but for broad-neelde-leaved.


On the palm tree: I added openstreetmap/id-tagging-schema#1034 to track this. I think some work needs to be done there first, before we can add a preset.

On the cactus: I could not find anything on the wiki nor on the forum. Fascinating, how biased the information is… :)

@bhousel
Copy link
Collaborator Author

bhousel commented Oct 24, 2023

I guess I could just make an icon of a tree with no leaves (branches only) and people could tag the leaf type if they want to?

I am assuming that most trees don't have leaf type tagging right now, so this would be an icon that would be shown pretty frequently?

bhousel added a commit that referenced this issue Oct 25, 2023
@tordans
Copy link

tordans commented Oct 26, 2023

I guess I could just make an icon of a tree with no leaves (branches only) and people could tag the leaf type if they want to?

I like the idea to use the icon without leaves as proxy for unspecified tree type! It will look nice and give a strong indicator to add the (right) leaves.

I always considered the skeleton icon to be reserved for a dead tree, but I guess we are a long way from adding this to our popular tagging practices (13 uses, 7 uses)

I am assuming that most trees don't have leaf type tagging right now, so this would be an icon that would be shown pretty frequently?

Yes, the current slim tree icons is visible all the time…
https://taginfo.openstreetmap.org/tags/natural=tree#combinations

  • 44_000_000 trees
  • 4_000_000 leave_type

Ah, you did this already
image

Awesome, will update the schema.

@bhousel
Copy link
Collaborator Author

bhousel commented Oct 26, 2023

Ah, you did this already

haha yes! I made that yesterday and published v5.6.
I actually really don't like how it turned out, and will probably rework it a bit and release a v5.6.1 patch, but we can start using it now.

@bhousel
Copy link
Collaborator Author

bhousel commented Oct 26, 2023

haha - icon still needs work 🙈

Screenshot 2023-10-26 at 5 21 08 PM

@bhousel
Copy link
Collaborator Author

bhousel commented Dec 28, 2023

I adjusted the tree icons today, they're looking a bit clearer at 15px now.

before

Screenshot 2023-12-28 at 4 46 47 PM

after

Screenshot 2023-12-28 at 4 48 23 PM

 
 

Drawing small icons is very challenging! The trick is to remove as much detail as possible, but then exaggerate whatever details remain and try to make them fit to the pixel grid so that the details are visible and not too muddy.

 
 

Here's how the trees look around a golf course:

broad leaved

Screenshot 2023-12-28 at 4 33 08 PM

needle leaved

Screenshot 2023-12-28 at 4 31 14 PM

palm

Screenshot 2023-12-28 at 4 29 36 PM

cactus

Screenshot 2023-12-28 at 4 37 40 PM

no leaves

Screenshot 2023-12-28 at 4 25 53 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants