Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert codespell from Drone to GH actions #3246

Merged
merged 3 commits into from
Aug 18, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/spellcheck.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: Codespell
on:
push:
pull_request:
branches:
- master
workflow_dispatch: {}
jobs:
spellcheck:
name: Spell Check
runs-on: ubuntu-20.04
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 1
- name: Set up Python 🐍
uses: actions/setup-python@v4
- name: Install codespell
run: |
python -m pip install --upgrade pip
pip install codespell
- name: Check spelling
run: codespell --skip=.git,./vendor,./MAINTAINERS,go.mod,go.sum --check-filenames --ignore-regex=.te# --ignore-words=.codespellignore
6 changes: 1 addition & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,7 @@ package-windows-bundle: build ## Package the Windows tarball bundle
./scripts/package-windows-bundle

.PHONY: test
test: codespell-test unit-tests integration-tests

.PHONY: codespell-test
codespell-test:
./scripts/codespell.sh
test: unit-tests integration-tests

.PHONY: unit-tests
unit-tests:
Expand Down
2 changes: 1 addition & 1 deletion developer-docs/testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ ___
## Integration Tests

Integration tests should be used to test a specific functionality of RKE2 that exists across multiple Go packages,
either via exported function calls, or more often, CLI comands. Integration tests should be used for "black box"
either via exported function calls, or more often, CLI commands. Integration tests should be used for "black box"
testing.

### Framework
Expand Down
12 changes: 0 additions & 12 deletions scripts/codespell.sh

This file was deleted.