Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert codespell from Drone to GH actions #3246

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Conversation

wgsuse
Copy link
Contributor

@wgsuse wgsuse commented Aug 18, 2022

Signed-off-by: Werner garcia [email protected]

Taken from: Derek Nola's PR k3s-io/k3s#6004

Proposed Changes

New version of codespell is finding more spelling errors, but also no longer just checking comments, but actual code.

  • Spelling mistake fixes
  • Codespell is now a GH action. This stops us from wasting valuable Drone time.

Types of Changes

Verification

Drone CI passes.
New GH Action Passes

Linked Issues

TBD

User-Facing Change


Further Comments

@wgsuse wgsuse self-assigned this Aug 18, 2022
@wgsuse wgsuse requested a review from a team as a code owner August 18, 2022 16:50
@wgsuse wgsuse requested review from dereknola and a team August 18, 2022 16:55
@wgsuse wgsuse merged commit 65d72a8 into rancher:master Aug 18, 2022
@wgsuse wgsuse deleted the codespell-fix branch August 18, 2022 17:06
luisrojas2 pushed a commit to luisrojas2/rke2 that referenced this pull request Aug 18, 2022
* Convert codespell from Drone to GH actions

* Update spellcheck.yaml

* Update .codespellignore

Signed-off-by: “luisrojas2” <[email protected]>
briandowns pushed a commit to briandowns/rke2 that referenced this pull request Aug 18, 2022
* Convert codespell from Drone to GH actions

* Update spellcheck.yaml

* Update .codespellignore

Signed-off-by: Brian Downs <[email protected]>
briandowns pushed a commit to briandowns/rke2 that referenced this pull request Aug 18, 2022
* Convert codespell from Drone to GH actions

* Update spellcheck.yaml

* Update .codespellignore

Signed-off-by: Brian Downs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants