Bump wrangler/lasso, client-go & k8s.io dependencies to k8s 1.30 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexandreLamarre
commented
Jul 31, 2024
•
alexandreLamarre
commented
- Modify main.go to not use out-of-date rancher command libraries
- Bump dependencies
- Clean up generated code
- Move tests to in-tree
- Clean up CI files
- Fix lock state mutability bug
alexandreLamarre
force-pushed
the
bump-deps
branch
from
c7d6106
to
1db496e
Compare
joshmeranda
approved these changes
Jul 31, 2024
| panic(err) | ||
| } | ||
| return | ||
| logrus.Infof("Generating code") |
There was a problem hiding this comment.
Why does this need to be pulled out of pkg/codegen/cleanup? Not necessarily a blocker just curious
There was a problem hiding this comment.
It doesn't have to be, but caused issues during the upgrade of dependencies
mallardduck
approved these changes
Jul 31, 2024
Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
alexandreLamarre
force-pushed
the
bump-deps
branch
from
6114d3a
to
ef06551
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.