fix interior state mutability data race

Signed-off-by: Alexandre Lamarre <[email protected]>

pkg/objectset/cache.go

@@ -175,6 +175,8 @@ func (c *lockableObjectSetRegisterAndCache) Lock(key relatedresource.Key) {
 		// nothing to lock
 		return
 	}
+	s.mutateMu.RLock()
+	defer s.mutateMu.RUnlock()
 	if s.ObjectSet == nil {
 		// nothing to lock
 		return
@@ -284,8 +286,9 @@ func (c *lockableObjectSetRegisterAndCache) deleteState(key relatedresource.Key)
 	c.stateMapLock.Lock()
 	delete(c.stateByKey, key)
 	c.stateMapLock.Unlock()
-
+	s.mutateMu.Lock()
 	s.ObjectSet = nil
+	s.mutateMu.Unlock()
 	s.Locked = false
 	c.stateChanges <- watch.Event{Type: watch.Deleted, Object: s}
 }

pkg/objectset/state.go

@@ -1,6 +1,7 @@
 package objectset
 
 import (
+	"sync"
 	"time"
 
 	"github.com/google/uuid"
@@ -38,6 +39,7 @@ func newObjectSetState(namespace, name string, obj objectSetState) *objectSetSta
 	obj.UID = types.UID(uuid.New().String())
 	obj.CreationTimestamp = metav1.NewTime(time.Now())
 	obj.ResourceVersion = "0"
+	obj.mutateMu = &sync.RWMutex{}
 	return &obj
 }
 
@@ -50,6 +52,8 @@ type objectSetState struct {
 	// ObjectSet is a pointer to the underlying ObjectSet whose state is being tracked
 	ObjectSet *objectset.ObjectSet `json:"objectSet,omitempty"`
 
+	mutateMu *sync.RWMutex
+
 	// Locked represents whether the ObjectSet should be locked in the cluster or not
 	Locked bool `json:"locked"`
 }