Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mail templates/views can now be localized #605

Merged
merged 26 commits into from
Oct 17, 2020
Merged

Mail templates/views can now be localized #605

merged 26 commits into from
Oct 17, 2020

Conversation

mjauvin
Copy link
Contributor

@mjauvin mjauvin commented Sep 21, 2020 •
edited
Loading

fixes #533

@mjauvin mjauvin added this to the 1.8.0 milestone Sep 21, 2020
@mjauvin mjauvin self-assigned this Sep 21, 2020
@mjauvin
Copy link
Contributor Author

mjauvin commented Sep 23, 2020 •
edited
Loading

For this to work with queued mails, we depend on octobercms/library#523

@mjauvin mjauvin modified the milestones: 1.8.0, 1.7.3 Sep 23, 2020
@mjauvin mjauvin changed the title [WIP] mail templates can now be localized mail templates can now be localized Sep 23, 2020
@mjauvin mjauvin changed the title mail templates can now be localized mail templates/views can now be localized Sep 23, 2020
@mjauvin mjauvin modified the milestones: 1.7.3, 1.8.0, 1.7.4 Oct 2, 2020
@mjauvin mjauvin mentioned this pull request Oct 13, 2020
Merged
LukeTowers
LukeTowers suggested changes Oct 13, 2020
View reviewed changes
classes/EventRegistry.php Show resolved Hide resolved
classes/EventRegistry.php Outdated Show resolved Hide resolved
classes/EventRegistry.php Show resolved Hide resolved
classes/EventRegistry.php Outdated Show resolved Hide resolved
classes/EventRegistry.php Outdated Show resolved Hide resolved
LukeTowers
LukeTowers suggested changes Oct 15, 2020
View reviewed changes
classes/EventRegistry.php Show resolved Hide resolved
classes/EventRegistry.php Outdated Show resolved Hide resolved
classes/EventRegistry.php Outdated Show resolved Hide resolved
classes/EventRegistry.php Outdated Show resolved Hide resolved
classes/EventRegistry.php Outdated Show resolved Hide resolved
classes/EventRegistry.php Outdated Show resolved Hide resolved
classes/EventRegistry.php Outdated Show resolved Hide resolved
@LukeTowers
Copy link
Contributor

LGTM now, @bennothommo any thoughts?

bennothommo
bennothommo approved these changes Oct 16, 2020
View reviewed changes
Plugin.php Outdated Show resolved Hide resolved
@bennothommo
Copy link
Contributor

Looks good to me, guys. Well done @mjauvin.

@mjauvin mjauvin merged commit 470b4ab into rainlab:master Oct 17, 2020
@mjauvin mjauvin deleted the localized-mail-templates branch October 17, 2020 12:43
@mjauvin mjauvin changed the title mail templates/views can now be localized Mail templates/views can now be localized Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennothommo bennothommo bennothommo approved these changes

@LukeTowers LukeTowers LukeTowers approved these changes

Assignees

@mjauvin mjauvin

Labels
Status: Completed Type: Enhancement
Projects
None yet
Milestone
1.7.4
Development

Successfully merging this pull request may close these issues.

Mail Templates translation
3 participants
@mjauvin @LukeTowers @bennothommo