Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail Templates translation #533

Closed
mjauvin opened this issue Dec 22, 2019 · 2 comments · Fixed by #605
Closed

Mail Templates translation #533

mjauvin opened this issue Dec 22, 2019 · 2 comments · Fixed by #605

Comments

@mjauvin
Copy link
Contributor

mjauvin commented Dec 22, 2019

Content files can be translated by affixing the locale code to the file name. We need to apply the same technique to translate Mail template files.

People are translating the mail templates themselves using the twig filters. This is a bad idea because when the mail is processed in a queue, it loses the locale setting.

@mjauvin
Copy link
Contributor Author

mjauvin commented Dec 26, 2019

I think this could be implemented by hooking into the "mailer.beforeSend" event and modifying the $view parameter in the event handler

@mjauvin mjauvin closed this as completed Mar 15, 2020
@mjauvin mjauvin removed this from the 1.7.2 milestone Jun 18, 2020
@aurelien-roy
Copy link
Contributor

Is this abandoned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants