Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] localized mail templates #534

Closed
wants to merge 1 commit into from
Closed

[WIP] localized mail templates #534

wants to merge 1 commit into from

Conversation

mjauvin
Copy link
Contributor

@mjauvin mjauvin commented Dec 29, 2019

use mail templates with locale suffix if it exists

fixes: #533

@mjauvin
Copy link
Contributor Author

mjauvin commented Dec 29, 2019

  • cannot use localized templates for privileged routes (e.g. /backend/auth)
  • localized mail templates must be registered using "author.plugin::mail.template-LOCALE" (e.g. rainlab.translate::mail.notification-fr)

@mjauvin
Copy link
Contributor Author

mjauvin commented Dec 29, 2019

@daftspunk are you sure the current locale would be available for a queued mail ?

@mjauvin mjauvin changed the title localized mail templates [WIP] localized mail templates Dec 29, 2019
@daftspunk
Copy link
Member

@daftspunk are you sure the current locale would be available for a queued mail ?

It would appear not :(

@mjauvin
Copy link
Contributor Author

mjauvin commented Dec 31, 2019

@daftspunk you're saying the locale is not available for a queued mail, can you provide a reproducible test for this?

@mjauvin mjauvin closed this Feb 11, 2020
@mjauvin mjauvin deleted the localized-mail-template branch February 12, 2020 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjauvin @daftspunk